[Forwardport] fix #17582 ./bin/magento config:show fails with a fatal error#18295
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Oct 3, 2018
mage2pratik:2.3-develop-PR-port-17993
Merged
[Forwardport] fix #17582 ./bin/magento config:show fails with a fatal error#18295magento-engcom-team merged 1 commit intomagento:2.3-developfrom mage2pratik:2.3-develop-PR-port-17993
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-17993
Conversation
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
Contributor
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Sep 28, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 3, 2018
… with a fatal error #18295
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17993
Description
Fixed Issues (if relevant)
Manual testing scenarios
Fork fresh Magento from GitHub
Install and configure Magento 2
Run the first command php bin/magento config:dump to dump the configuration value
show the config dump php bin/magento config:show (Now it shows correctly the value rather then PHP fatel error) (please check attached file show.txt)
show.txt
Run the php unit test
$ php vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Config
PHPUnit 6.2.4 by Sebastian Bergmann and contributors.
............................................................... 63 / 395 ( 15%)
............................................................... 126 / 395 ( 31%)
............................................................... 189 / 395 ( 47%)
............................................................... 252 / 395 ( 63%)
............................................................... 315 / 395 ( 79%)
............................................................... 378 / 395 ( 95%)
................. 395 / 395 (100%)
Time: 855 ms, Memory: 28.00MB
OK (395 tests, 1181 assertions)
Contribution checklist